Fix booking time calculation for multi-day flex trip searches #7255
+171
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7255 +/- ##
=============================================
+ Coverage 72.13% 72.17% +0.04%
- Complexity 21085 21090 +5
=============================================
Files 2297 2298 +1
Lines 85233 85189 -44
Branches 8489 8481 -8
=============================================
+ Hits 61481 61485 +4
+ Misses 20772 20733 -39
+ Partials 2980 2971 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vpaturet
force-pushed
the
fix-flex-booking-time-multiday
branch
2 times, most recently
from
cc8912b to
c137a5b
Compare
vpaturet
force-pushed
the
fix-flex-booking-time-multiday
branch
2 times, most recently
from
642bb57 to
2dfbc1f
Compare
When a bookingTime parameter is provided in flex trip queries, the requestedBookingTime was calculated once relative to the search date's start-of-service, then reused for all FlexServiceDate objects across multiple days. This caused valid trips to be incorrectly filtered out when the booking time and trip departure were on different days. Changed FlexServiceDate to store the original Instant and ZoneId, then calculate seconds-since-start-of-service on-demand relative to each date's own start-of-service. This ensures booking time comparisons use the correct reference point for each service date.
vpaturet
force-pushed
the
fix-flex-booking-time-multiday
branch
from
2dfbc1f to
e4c3d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in #7203, when a bookingTime parameter is provided in flex trip queries, the requestedBookingTime was calculated once relative to the search date's start-of-service, then reused for all FlexServiceDate objects across multiple days. This caused valid trips to be incorrectly filtered out when the booking time and trip departure were on different days.
Changed FlexServiceDate to store the original Instant and ZoneId, then calculate seconds-since-start-of-service on-demand relative to each date's own start-of-service. This ensures booking time comparisons use the correct reference point for each service date.
Issue
Closes #7203
Unit tests
Updated unit tests
Documentation
No